From e802f41d44c8c68c26469440eb1299329b886f41 Mon Sep 17 00:00:00 2001
From: Simon Schneegans <code@simonschneegans.de>
Date: Sat, 2 Apr 2022 13:49:07 +0200
Subject: [PATCH] :wrench: Apparition is not available on GNOME 3.36

---
 src/Apparition.js                                 |   5 +++--
 tests/generate-references.sh                      |   5 ++++-
 .../apparition-close-gnome-wayland-nested-32.png  | Bin 654 -> 0 bytes
 .../apparition-close-gnome-xsession-32.png        | Bin 654 -> 0 bytes
 .../apparition-open-gnome-wayland-nested-32.png   | Bin 654 -> 0 bytes
 .../apparition-open-gnome-xsession-32.png         | Bin 654 -> 0 bytes
 tests/run-test.sh                                 |   5 ++++-
 7 files changed, 11 insertions(+), 4 deletions(-)
 delete mode 100644 tests/references/apparition-close-gnome-wayland-nested-32.png
 delete mode 100644 tests/references/apparition-close-gnome-xsession-32.png
 delete mode 100644 tests/references/apparition-open-gnome-wayland-nested-32.png
 delete mode 100644 tests/references/apparition-open-gnome-xsession-32.png

diff --git a/src/Apparition.js b/src/Apparition.js
index d8291e5..981fb16 100644
--- a/src/Apparition.js
+++ b/src/Apparition.js
@@ -37,9 +37,10 @@ var Apparition = class Apparition {
 
   // ---------------------------------------------------------------------------- metadata
 
-  // The effect is available on all GNOME Shell versions supported by this extension.
+  // The effect is not available on GNOME Shell 3.36 as it requires scaling of the window
+  // actor.
   static getMinShellVersion() {
-    return [3, 36];
+    return [3, 38];
   }
 
   // This will be called in various places where a unique identifier for this effect is
diff --git a/tests/generate-references.sh b/tests/generate-references.sh
index 3857ed6..3d2b7ea 100755
--- a/tests/generate-references.sh
+++ b/tests/generate-references.sh
@@ -168,13 +168,16 @@ echo "Entering test mode."
 set_setting "test-mode" true
 do_in_pod gsettings set org.gnome.mutter center-new-windows true
 
-capture_effect "apparition"
 capture_effect "energize-a"
 capture_effect "energize-b"
 capture_effect "fire"
 capture_effect "tv"
 capture_effect "wisps"
 
+if [[ "${FEDORA_VERSION}" -gt 32 ]]; then
+  capture_effect "apparition"
+fi
+
 if [[ "${FEDORA_VERSION}" -gt 33 ]]; then
   capture_effect "trex"
   capture_effect "broken-glass"
diff --git a/tests/references/apparition-close-gnome-wayland-nested-32.png b/tests/references/apparition-close-gnome-wayland-nested-32.png
deleted file mode 100644
index 218ee9245202d6d7dd5775d9cfa7cdd08b9ba57f..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 654
zcmeAS@N?(olHy`uVBq!ia0vp^DIm<j3?$ucQqzDGOS+@4BLl<6e(pbstU$g(vPY0F
z14ES>14Ba#1H&(%P{RubhEf9thF1v;3|2E37{m+a><Y92N~{a;32|+lcZ5^Tr?78J
ze9fZLNjn(jT$mNyGFn$N$-CChI*{M9N!P2uEV#0I#y&;66hprfm&A4v!*DJ4+`8EZ
zB}}7pI@deIHfOc3E$H3Mt>MS6;#D<$udqQ_+2oz}F->XBE1eVCG+eWd{7W0=9<G_W
zzjE3h8OwN+z;XfI;Ml4K{yCHC=NxiR>EhK2&~(c&52>;WuPvXl%R8gbBD9)E(_hjo
zhE>TUqiJc)%zgj=|34pc`7Y4qj7i?^E|%9BraAyQ0?CPfWeg1L4ZzT_U|?YG1Ij<J
zK5%qBkT&ylaSX}0_x56Rc$0%f>%&+RHMOuy2RSdC>N*z|_Thhhr17;=(_ER1@87M<
zkLd3HYrwo=BWLi2r56~ll!+(u-+1YMkzx0TEBF2xuq{%sI*^#dpgr@t*Gk4cr6o3(
zo)rpd?zM28l$KmA@<V5i!+fUnXP2A#j9QCx1^2fGA5c25qTj^3T3qU%v3(*(4BLUL
zCfAcYuJjhxHs7{>@Q=~SR*f<3*{OL7GrT^Xd?UGOZ_Cd=p;DF1&nCQ+?J;~7_i^rn
zEo);`HpZ=cR=jVGSH(Tim8S0-Om5`2o3KhL>wcT9nA`ZPqdS1VkU2}Cb@v9gkIH}A
zD}+}G_B*jY3je|VQSXl%ON;1|35s<}L5GAiSvvJyLVma`;cV{U7Sr@ra_JCIbZX%c
eL}hH+#(z_fr{vW8h<ae?GI+ZBxvX<aXaWE~0{N~0

diff --git a/tests/references/apparition-close-gnome-xsession-32.png b/tests/references/apparition-close-gnome-xsession-32.png
deleted file mode 100644
index 218ee9245202d6d7dd5775d9cfa7cdd08b9ba57f..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 654
zcmeAS@N?(olHy`uVBq!ia0vp^DIm<j3?$ucQqzDGOS+@4BLl<6e(pbstU$g(vPY0F
z14ES>14Ba#1H&(%P{RubhEf9thF1v;3|2E37{m+a><Y92N~{a;32|+lcZ5^Tr?78J
ze9fZLNjn(jT$mNyGFn$N$-CChI*{M9N!P2uEV#0I#y&;66hprfm&A4v!*DJ4+`8EZ
zB}}7pI@deIHfOc3E$H3Mt>MS6;#D<$udqQ_+2oz}F->XBE1eVCG+eWd{7W0=9<G_W
zzjE3h8OwN+z;XfI;Ml4K{yCHC=NxiR>EhK2&~(c&52>;WuPvXl%R8gbBD9)E(_hjo
zhE>TUqiJc)%zgj=|34pc`7Y4qj7i?^E|%9BraAyQ0?CPfWeg1L4ZzT_U|?YG1Ij<J
zK5%qBkT&ylaSX}0_x56Rc$0%f>%&+RHMOuy2RSdC>N*z|_Thhhr17;=(_ER1@87M<
zkLd3HYrwo=BWLi2r56~ll!+(u-+1YMkzx0TEBF2xuq{%sI*^#dpgr@t*Gk4cr6o3(
zo)rpd?zM28l$KmA@<V5i!+fUnXP2A#j9QCx1^2fGA5c25qTj^3T3qU%v3(*(4BLUL
zCfAcYuJjhxHs7{>@Q=~SR*f<3*{OL7GrT^Xd?UGOZ_Cd=p;DF1&nCQ+?J;~7_i^rn
zEo);`HpZ=cR=jVGSH(Tim8S0-Om5`2o3KhL>wcT9nA`ZPqdS1VkU2}Cb@v9gkIH}A
zD}+}G_B*jY3je|VQSXl%ON;1|35s<}L5GAiSvvJyLVma`;cV{U7Sr@ra_JCIbZX%c
eL}hH+#(z_fr{vW8h<ae?GI+ZBxvX<aXaWE~0{N~0

diff --git a/tests/references/apparition-open-gnome-wayland-nested-32.png b/tests/references/apparition-open-gnome-wayland-nested-32.png
deleted file mode 100644
index 218ee9245202d6d7dd5775d9cfa7cdd08b9ba57f..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 654
zcmeAS@N?(olHy`uVBq!ia0vp^DIm<j3?$ucQqzDGOS+@4BLl<6e(pbstU$g(vPY0F
z14ES>14Ba#1H&(%P{RubhEf9thF1v;3|2E37{m+a><Y92N~{a;32|+lcZ5^Tr?78J
ze9fZLNjn(jT$mNyGFn$N$-CChI*{M9N!P2uEV#0I#y&;66hprfm&A4v!*DJ4+`8EZ
zB}}7pI@deIHfOc3E$H3Mt>MS6;#D<$udqQ_+2oz}F->XBE1eVCG+eWd{7W0=9<G_W
zzjE3h8OwN+z;XfI;Ml4K{yCHC=NxiR>EhK2&~(c&52>;WuPvXl%R8gbBD9)E(_hjo
zhE>TUqiJc)%zgj=|34pc`7Y4qj7i?^E|%9BraAyQ0?CPfWeg1L4ZzT_U|?YG1Ij<J
zK5%qBkT&ylaSX}0_x56Rc$0%f>%&+RHMOuy2RSdC>N*z|_Thhhr17;=(_ER1@87M<
zkLd3HYrwo=BWLi2r56~ll!+(u-+1YMkzx0TEBF2xuq{%sI*^#dpgr@t*Gk4cr6o3(
zo)rpd?zM28l$KmA@<V5i!+fUnXP2A#j9QCx1^2fGA5c25qTj^3T3qU%v3(*(4BLUL
zCfAcYuJjhxHs7{>@Q=~SR*f<3*{OL7GrT^Xd?UGOZ_Cd=p;DF1&nCQ+?J;~7_i^rn
zEo);`HpZ=cR=jVGSH(Tim8S0-Om5`2o3KhL>wcT9nA`ZPqdS1VkU2}Cb@v9gkIH}A
zD}+}G_B*jY3je|VQSXl%ON;1|35s<}L5GAiSvvJyLVma`;cV{U7Sr@ra_JCIbZX%c
eL}hH+#(z_fr{vW8h<ae?GI+ZBxvX<aXaWE~0{N~0

diff --git a/tests/references/apparition-open-gnome-xsession-32.png b/tests/references/apparition-open-gnome-xsession-32.png
deleted file mode 100644
index 218ee9245202d6d7dd5775d9cfa7cdd08b9ba57f..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 654
zcmeAS@N?(olHy`uVBq!ia0vp^DIm<j3?$ucQqzDGOS+@4BLl<6e(pbstU$g(vPY0F
z14ES>14Ba#1H&(%P{RubhEf9thF1v;3|2E37{m+a><Y92N~{a;32|+lcZ5^Tr?78J
ze9fZLNjn(jT$mNyGFn$N$-CChI*{M9N!P2uEV#0I#y&;66hprfm&A4v!*DJ4+`8EZ
zB}}7pI@deIHfOc3E$H3Mt>MS6;#D<$udqQ_+2oz}F->XBE1eVCG+eWd{7W0=9<G_W
zzjE3h8OwN+z;XfI;Ml4K{yCHC=NxiR>EhK2&~(c&52>;WuPvXl%R8gbBD9)E(_hjo
zhE>TUqiJc)%zgj=|34pc`7Y4qj7i?^E|%9BraAyQ0?CPfWeg1L4ZzT_U|?YG1Ij<J
zK5%qBkT&ylaSX}0_x56Rc$0%f>%&+RHMOuy2RSdC>N*z|_Thhhr17;=(_ER1@87M<
zkLd3HYrwo=BWLi2r56~ll!+(u-+1YMkzx0TEBF2xuq{%sI*^#dpgr@t*Gk4cr6o3(
zo)rpd?zM28l$KmA@<V5i!+fUnXP2A#j9QCx1^2fGA5c25qTj^3T3qU%v3(*(4BLUL
zCfAcYuJjhxHs7{>@Q=~SR*f<3*{OL7GrT^Xd?UGOZ_Cd=p;DF1&nCQ+?J;~7_i^rn
zEo);`HpZ=cR=jVGSH(Tim8S0-Om5`2o3KhL>wcT9nA`ZPqdS1VkU2}Cb@v9gkIH}A
zD}+}G_B*jY3je|VQSXl%ON;1|35s<}L5GAiSvvJyLVma`;cV{U7Sr@ra_JCIbZX%c
eL}hH+#(z_fr{vW8h<ae?GI+ZBxvX<aXaWE~0{N~0

diff --git a/tests/run-test.sh b/tests/run-test.sh
index 3743530..29db5d8 100755
--- a/tests/run-test.sh
+++ b/tests/run-test.sh
@@ -197,13 +197,16 @@ echo "Entering test mode."
 set_setting "test-mode" true
 do_in_pod gsettings set org.gnome.mutter center-new-windows true
 
-test_effect "apparition"
 test_effect "energize-a"
 test_effect "energize-b"
 test_effect "fire"
 test_effect "tv"
 test_effect "wisps"
 
+if [[ "${FEDORA_VERSION}" -gt 32 ]]; then
+  test_effect "apparition"
+fi
+
 if [[ "${FEDORA_VERSION}" -gt 33 ]]; then
   test_effect "trex"
   test_effect "broken-glass"