From fd5d195446b55082e37ef53bc167db71690903ad Mon Sep 17 00:00:00 2001 From: Onuralp SEZER Date: Sun, 15 Jan 2023 14:37:13 +0300 Subject: [PATCH 1/3] =?UTF-8?q?=F0=9F=93=9D=20fedora=20package=20name=20fo?= =?UTF-8?q?r=20readme?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Onuralp SEZER --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index ed1f5cc..b2794d1 100644 --- a/README.md +++ b/README.md @@ -191,7 +191,7 @@ You can either download the effects from the KDE store (a), download a stable ve :warning: **You need at least KWin 5.25.0 for the Burn-My-Windows effects.** -:warning: **If the color picker widgets in the effect settings do not work for you, you may have to install a package called `libkf5widgetsaddons-dev` (Kubuntu, KDE Neon, ...) or `kwidgetsaddons-devel` (Fedora, OpenSuse, ...).** +:warning: **If the color picker widgets in the effect settings do not work for you, you may have to install a package called `libkf5widgetsaddons-dev` (Kubuntu, KDE Neon, ...) or `kf5-kwidgetsaddons-devel`, `kwidgetsaddons-devel` (Fedora, OpenSuse, ...).** ### a) Download from the [KDE Store](https://store.kde.org/p/1861183) From c21790f5a86f8d7544e3f28473056d34aae3181d Mon Sep 17 00:00:00 2001 From: Simon Schneegans Date: Tue, 17 Jan 2023 20:13:07 +0100 Subject: [PATCH 2/3] :beetle: Fix issue #278 --- extension.js | 14 +++++++++----- prefs.js | 17 +++++++++++------ 2 files changed, 20 insertions(+), 11 deletions(-) diff --git a/extension.js b/extension.js index 4462862..4498a13 100644 --- a/extension.js +++ b/extension.js @@ -89,10 +89,14 @@ class Extension { '/org/freedesktop/UPower'); // This is used to get the current power profile. - const PowerProfilesProxy = Gio.DBusProxy.makeProxyWrapper( - utils.getStringResource('/interfaces/net.hadess.PowerProfiles.xml')); - this._powerProfilesProxy = new PowerProfilesProxy( - Gio.DBus.system, 'net.hadess.PowerProfiles', '/net/hadess/PowerProfiles'); + try { + const PowerProfilesProxy = Gio.DBusProxy.makeProxyWrapper( + utils.getStringResource('/interfaces/net.hadess.PowerProfiles.xml')); + this._powerProfilesProxy = new PowerProfilesProxy( + Gio.DBus.system, 'net.hadess.PowerProfiles', '/net/hadess/PowerProfiles'); + } catch (e) { + // Maybe the service is masked... + } // We will monkey-patch these methods. Let's store the original ones. this._origAddWindowClone = Workspace.prototype._addWindowClone; @@ -391,7 +395,7 @@ class Extension { let disableOnBattery = this._settings.get_boolean('disable-on-battery') && this._upowerProxy.OnBattery; let disableOnPowerSave = this._settings.get_boolean('disable-on-power-save') && - this._powerProfilesProxy.ActiveProfile == 'power-saver'; + this._powerProfilesProxy && this._powerProfilesProxy.ActiveProfile == 'power-saver'; if ((disableOnBattery || disableOnPowerSave) && previewNick == '') { this._fixAnimationTimes(isDialogWindow, forOpening, null); diff --git a/prefs.js b/prefs.js index 5ab36a1..dc2b818 100644 --- a/prefs.js +++ b/prefs.js @@ -108,15 +108,20 @@ var PreferencesDialog = class PreferencesDialog { // Check whether the power profiles daemon is available - if not, we hide the // corresponding settings row. - const PowerProfilesProxy = Gio.DBusProxy.makeProxyWrapper( - utils.getStringResource('/interfaces/net.hadess.PowerProfiles.xml')); - let powerProfilesProxy = new PowerProfilesProxy( - Gio.DBus.system, 'net.hadess.PowerProfiles', '/net/hadess/PowerProfiles'); + let hasPowerProfiles = false; + try { + const PowerProfilesProxy = Gio.DBusProxy.makeProxyWrapper( + utils.getStringResource('/interfaces/net.hadess.PowerProfiles.xml')); + let powerProfilesProxy = new PowerProfilesProxy( + Gio.DBus.system, 'net.hadess.PowerProfiles', '/net/hadess/PowerProfiles'); - if (powerProfilesProxy.get_name_owner() == null) { - this._builder.get_object('disable-on-power-save-row').set_visible(false); + hasPowerProfiles = powerProfilesProxy.get_name_owner() != null; + } catch (e) { + // Maybe the service is masked... } + this._builder.get_object('disable-on-power-save-row').set_visible(hasPowerProfiles); + // Starting with GNOME Shell 42, the settings dialog uses libadwaita (at least most of // the time - it seems that pop!_OS does not support libadwaita even on GNOME 42). We // have to use a different layout, as the stack sidebar looks pretty ugly with the From a8c10352537eff07f0e81f883afb2d712b34dbc9 Mon Sep 17 00:00:00 2001 From: Simon Schneegans Date: Tue, 17 Jan 2023 20:13:21 +0100 Subject: [PATCH 3/3] :memo: Add changelog entry --- docs/changelog.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/docs/changelog.md b/docs/changelog.md index 2d9f7af..b1f002d 100644 --- a/docs/changelog.md +++ b/docs/changelog.md @@ -5,6 +5,14 @@ SPDX-License-Identifier: CC-BY-4.0 # Changelog of the Burn-My-Windows Extension +## [Burn My Windows 25](https://github.com/schneegans/Burn-My-Windows/releases/tag/v25) + +**Release Date:** 2023-01-17 + +#### Bug Fixes + +* Fixed an issue which prevented the extension from loading if `power-profiles-daemon` was masked. + ## [Burn My Windows 24](https://github.com/schneegans/Burn-My-Windows/releases/tag/v24) **Release Date:** 2023-01-14