♻️ Refactor how preferences pages are set up

This commit is contained in:
Simon Schneegans
2022-01-22 20:24:38 +01:00
parent 55727f7c2b
commit a5f7769e58
10 changed files with 37 additions and 57 deletions
+3 -5
View File
@@ -61,7 +61,7 @@ var Fire = class Fire {
// This is called by the preferences dialog. It loads the settings page for this effect,
// binds all properties to the settings and appends the page to the main stack of the
// preferences dialog.
static initPreferences(dialog) {
static getPreferences(dialog) {
// Add the settings page to the builder.
dialog.getBuilder().add_from_resource(`/ui/${utils.getGTKString()}/Fire.ui`);
@@ -89,10 +89,8 @@ var Fire = class Fire {
// Initialize the fire-preset dropdown.
Fire._createFirePresets(dialog);
// Finally, append the settings page to the main stack.
const stack = dialog.getBuilder().get_object('main-stack');
stack.add_titled(
dialog.getBuilder().get_object('fire-prefs'), Fire.getNick(), Fire.getLabel());
// Finally, return the new settings page.
return dialog.getBuilder().get_object('fire-prefs');
}
// ---------------------------------------------------------------- API for extension.js